Hi,
  I have two comments.

1.       BaseTools parameter is required to be supported for compatibility, 
because this usage is mentioned in EDKII_UserManual.pdf document. Some users 
have used it. In fact, ". edksetup.sh BaseTools" is same to ". edksetup.sh".

2.       In below script, BaseTools/BuildEnv $* can be cleanup to remove $*, 
because no parameter is required.

if [ -z "$WORKSPACE" ]
then
  . BaseTools/BuildEnv $*
else
  . $WORKSPACE/BaseTools/BuildEnv $*
fi

Thanks
Liming
From: parmeshwr_pra...@dell.com<mailto:parmeshwr_pra...@dell.com> 
[mailto:parmeshwr_pra...@dell.com]
Sent: Thursday, January 23, 2014 4:02 PM
To: 
edk2-comm...@lists.sourceforge.net<mailto:edk2-comm...@lists.sourceforge.net>
Subject: edk2/edksetup.sh patch to solve command line parameter

Hi All,

I see there is a problem in "edksetup.sh" file. It accept one parameter "-?, 
-h, --help" for printing help message.
If we give any other parameter to this it goes and set old environment with 
help message.  Expected behavior should be either to print
The help message or set environment. It is not able to handle any garbage 
parameter.
I am sending patch for this problem, please review and commit to main stream.

Even help message was not clear I changes that also.

Incorrect behavior :
:~/Development/edk2$ source edksetup.sh ---jjdcncn
Loading previous configuration from $WORKSPACE/Conf/BuildEnv.sh
WORKSPACE: /home/param/Development/edk2
EDK_TOOLS_PATH: /home/param/Development/edk2/BaseTools

Correct behavior:
:~/Development/edk2$ source edksetup.sh -h
BaseTools Usage: '. edksetup.sh'

Please note: This script must be 'sourced' so the environment can be changed.
(Either '. edksetup.sh' or 'source edksetup.sh')

Correct behavior:
:~/Development/edk2$ source edksetup.sh
Loading previous configuration from $WORKSPACE/Conf/BuildEnv.sh
WORKSPACE: /home/param/Development/edk2
EDK_TOOLS_PATH: /home/param/Development/edk2/BaseTools


Best Regards,
Parmeshwr Prasad
Tel : +91-9743262018
[cid:image002.png@01CE781A.38F61FE0]

<<inline: image001.png>>

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
edk2-comm...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to