I have added reviewed-by lines under the patches approved. Go ahead and check
them in. Some of them have comments / concerns...
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Friday, January 24, 2014 11:07 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net; Brendan Jackman
Subject: [PATCH] Various fixes for the EFI Shell
Importance: High
Dear EFI Shell maintainer,
Please find the following fixes for the EFI Shell.
Here is an overview of what the following patchset does. Some commit messages
contain a more detailed description of what they achieve.
0001-ShellPkg-Shell.c-Error-out-when-ProcessCommandLine-f.patch
ShellPkg/Shell.c: Error out when ProcessCommandLine fails
I think that this will cause memory leaks and protocols left installed after
the image has exited. The function cannot return this early without more
cleanup.
0002-ShellPkg-Shell.c-Manually-parse-parameters.patch
This patch fixes EFI Shell command line parsing.
For instance, it did not support this command line: `shell.efi
cp -r foo bar` because '-r' is not a supported argument.
Shell parameters must be non-case sensitive. Maybe use the ShellNoCaseCompare
API?
0003-ShellPkg-Shell-Fix-reporting-of-exit-status-in-Shell.patch
ShellPkg/Shell: Fix reporting of exit status in
ShellProtocol.Execute
The Shell did not report if a command was failing.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
0004-ShellPkg-ShellProtocol.c-Don-t-overwrite-Status-in-I.patch
ShellPkg/ShellProtocol.c: Don't overwrite Status in
InternalShellExecuteDevicePath
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
0005-ShellLib-UefiShellLib.c-Fix-doc-comment-for-ShellOpe.patch
AArch64Mmu.c.patch
ShellLib/UefiShellLib.c: Fix doc comment for
ShellOpenFileMetaArg
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
0006-ShellPkg-UefiShellLib.c-Execute-Return-a-Command-sta.patch
ShellPkg/UefiShellLib.c: Execute: Return a Command status even
in the old shell
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
0007-ShellPkg-ShellProtocol.c-Make-Argv-0-the-full-file-p.patch
ShellPkg/ShellProtocol.c: Make Argv[0] the full file path of the command
Required by the EFI Shell spec
I think that this parch will induce memory leaks when it returns early since
the cleanup code at the bottom of the function never happen.
0008-ShellPkg-ShellProtocol.c-Don-t-put-consective-s-in-f.patch
ShellPkg/ShellProtocol.c: Don't put consective "\"s in file paths
The UEFI and UEFI Shell specs do not allow consecutive path separators.
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
Thanks,
Olivier
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
