Of all the gin joints in all the towns in all the world, Laszlo Ersek had to walk into mine at 16:41:41 on Wednesday 29 January 2014 and say:
> On 01/29/14 23:23, Jordan Justen wrote: > > Once we support ACPI S3, then we can restore this to > > being allocated as ACPI NVS memory. > > > > At that time we should also have a way to disable > > S3 support in QEMU. When we detect that S3 is > > disabled in QEMU, then we can allocate this as regular > > Boot Services Data memory. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Jordan Justen <[email protected]> > > Cc: Bill Paul <[email protected]> > > Cc: Laszlo Ersek <[email protected]> > > --- > > > > OvmfPkg/PlatformPei/Fv.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/OvmfPkg/PlatformPei/Fv.c b/OvmfPkg/PlatformPei/Fv.c > > index fbdb597..1ee417a 100644 > > --- a/OvmfPkg/PlatformPei/Fv.c > > +++ b/OvmfPkg/PlatformPei/Fv.c > > @@ -36,12 +36,12 @@ PeiFvInitialization ( > > > > // > > // Create a memory allocation HOB for the PEI FV. > > // > > > > - // This is marked as ACPI NVS so it will still be available on S3 > > resume. + // Note: This should be changed to ACPI NVS when S3 resume is > > enabled. > > > > // > > BuildMemoryAllocationHob ( > > > > PcdGet32 (PcdOvmfPeiMemFvBase), > > PcdGet32 (PcdOvmfPeiMemFvSize), > > > > - EfiACPIMemoryNVS > > + EfiBootServicesData > > > > ); > > > > // > > Works for me if works for Bill! :) > > Reviewed-by: Laszlo Ersek <[email protected]> This was in fact the same workaround I tested when I first ran into this. Works fine for me. -Bill -- ============================================================================= -Bill Paul (510) 749-2329 | Senior Member of Technical Staff, [email protected] | Master of Unix-Fu - Wind River Systems ============================================================================= "I put a dollar in a change machine. Nothing changed." - George Carlin ============================================================================= ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
