Jordan: Thanks for your catch this typo. The patch is good to me. Reviewed-by: Liming Gao <[email protected]>
Thanks Liming -----Original Message----- From: Jordan Justen [mailto:[email protected]] Sent: Thursday, January 30, 2014 5:02 AM To: [email protected] Subject: [edk2] [PATCH 1/2] edksetup.sh: Code style Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen <[email protected]> --- edksetup.sh | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/edksetup.sh b/edksetup.sh index 39b76e1..7285dfe 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -44,19 +44,20 @@ function SetupEnv() function SourceEnv() { -if [ \ - "$1" = "-?" -o \ - "$1" = "-h" -o \ - "$1" = "--help" \ - ] -then - HelpMsg - return -else - SetupEnv "$*" -fi + if [ \ + "$1" = "-?" -o \ + "$1" = "-h" -o \ + "$1" = "--help" \ + ] + then + HelpMsg + return + else + SetupEnv "$*" + fi } -if [ $# -gt 1 ] + +if [ $# -gt 1 ] then HelpMsg return @@ -64,6 +65,7 @@ elif [ $# -eq 1 ] && [ "$1" != "BaseTool" ] then HelpMsg return -fi +fi + SourceEnv "$*" -- 1.8.5.3 ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
