Alexei,
The fix is checked into edk2 revision 15216, which removed obsolete
code and updated the function's return type to VOID.
Please help to confirm.
Thanks
Elvin
-----Original Message-----
From: Gao, Liming [mailto:[email protected]]
Sent: Saturday, February 08, 2014 9:37 AM
To: [email protected]
Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function
Good comments. Yes. We will fix them.
-----Original Message-----
From: Alexei Fedorov [mailto:[email protected]]
Sent: Thursday, January 30, 2014 7:15 PM
To: [email protected]
Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function
Liming,
I didn't hit any issue with that code, but have been trying to work out the
reason of the compilation error.
As UnicodeFiFoRemoveOneKey() is called only when FIFO buffer is not empty,
should the obsolete code be removed & the function's return type changed to
VOID?
Do you plan to implement a patch for issues 1) & 2)?
Thanks.
Alexei.
------------------------------
>Message: 6
>Date: Thu, 30 Jan 2014 02:19:18 +0000
>From: "Gao, Liming" <[email protected]>
>Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey()
>function
>To: "[email protected]"
> <[email protected]>
>Message-ID:
>
><4a89e2ef3dfedb4c8bfde51014f606a1117c1...@shsmsx102.ccr.corp.intel.com>
>Content-Type: text/plain; charset="us-ascii"
>Alexei:
> I agree 1) and 2) are issues. But, they should not happen. Before
> UnicodeFiFoRemoveOneKey() is called, while statement has checked
> >IsUnicodeFiFoEmpty() to make sure Fifo buffer is not empty. So,
> UnicodeFiFoRemoveOneKey() doesn't enter into Fifo empty case. Do you meet
> with >the real problem or just compiler issue?
>Line 1202: while (!IsUnicodeFiFoEmpty (TerminalDevice) && !IsEfiKeyFiFoFull
>(TerminalDevice)) {
>Line 1218: UnicodeFiFoRemoveOneKey (TerminalDevice, &UnicodeChar);
>Thanks
>Liming
-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered
in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office
110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company
No: 2548782
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable security
intelligence. It gives you real-time visual feedback on key security issues and
trends. Skip the complicated setup - simply import a virtual appliance and go
from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
