Garrett,

I pushed your fix about 'adding EfiReservedMemoryType regions to FDT'.

 

But there is a misinterpretation of the Linux Booting protocol into the
other part of your patch. The Linux Boot protocol says:

 

"The image must be placed at the specified offset (currently 0x80000)

from the start of the system RAM and called there. The start of the

system RAM must be aligned to 2MB."

Source: https://www.kernel.org/doc/Documentation/arm64/booting.txt

 

Your patch tries to load Linux kernel on any 2MB boundary if it fails at
'SystemMemoryBase + 0x80000' - which is wrong.

If it fails at 'SystemMemoryBase + 0x80000' then it should just abort Linux
loading.

 

Thanks,

Olivier

 

From: Kirkendall, Garrett [mailto:garrett.kirkend...@amd.com] 
Sent: 17 February 2014 17:04
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] ArmPkg/Library/BdsLib: Fix Linux kernel load when
1st call to BdsLoadImage fails.

 

Dear ArmPkg maintainers,

 

Please consider the attached patch that handles loading the Linux kernel
when the first call to BdsLoadImage fails.  Also, it makes sure that the
PSCI disabled processor holding pen can be allocated when loading the kernel
image.

 

Garrett Kirkendall   Description: Description: Description: purple
SMTS Firmware Engineer | AMD Technology & Engineering
7171 Southwest Parkway, Austin, TX 78735 USA 
Description: Description: Description: image004
<https://www.facebook.com/AMD> facebook  |   <http://www.amd.com/> amd.com

 

<<image001.png>>

<<image002.png>>

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to