On 02/26/14 20:25, Jordan Justen wrote:
> On Fri, Feb 21, 2014 at 3:58 PM, Laszlo Ersek <ler...@redhat.com> wrote:
>> GraphicsConsoleDxe (a UEFI_DRIVER under MdeModulePkg/Universal/Console)
>> determines the preferred video resolution from the dynamic PCDs
>> - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution
>> - gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution
>>
>> In one of the next patches, we'd like to change these PCDs. In order for
>> GraphicsConsoleDxe to retrieve the new values dynamically,
>> - it must be linked with the non-null instance of PcdLib,
>> - OvmfPkg must provide dynamic defaults.
>>
>> We keep MdeModulePkg's 800x600 default resolution. (The UEFI specification
>> requires video drivers to support 800x600.)
>
> I think the only requirement is to be able to support 800x600, so I
> think we could make the default mode be something else.
I think leaving the default at 800x600 is a good idea because those PCDs
are independent of the actual video driver. Setting 1680x1050 is not
useful if the user chooses Cirrus. (I might have misunderstood you).
> I don't think QEMU provides any feedback of the resolution of the
> screen in which the VM is running, right?
I guess QXL might provide some fancy register...
Thanks
Laszlo
> That could be interesting
> information to feed to the guest. (Admittedly, there is not always a
> GUI running when QEMU is running.)
>
> -Jordan
>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
>> ---
>> OvmfPkg/OvmfPkgIa32.dsc | 7 ++++++-
>> OvmfPkg/OvmfPkgIa32X64.dsc | 7 ++++++-
>> OvmfPkg/OvmfPkgX64.dsc | 7 ++++++-
>> 3 files changed, 18 insertions(+), 3 deletions(-)
>>
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
>> index 88d479d..78ab4e8 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -320,6 +320,8 @@
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
>>
>>
>>
>> ################################################################################
>> @@ -423,7 +425,10 @@
>> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
>> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
>> - MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
>> + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf {
>> + <LibraryClasses>
>> + PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>> + }
>> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
>> <LibraryClasses>
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>> index f19b658..9fbdf56 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -326,6 +326,8 @@
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
>>
>>
>>
>> ################################################################################
>> @@ -430,7 +432,10 @@
>> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
>> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
>> - MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
>> + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf {
>> + <LibraryClasses>
>> + PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>> + }
>> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
>> <LibraryClasses>
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
>> index a927564..5776c0e 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -347,6 +347,8 @@
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|0
>> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800
>> + gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
>>
>>
>>
>> ################################################################################
>> @@ -450,7 +452,10 @@
>> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
>> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
>> - MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
>> + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf {
>> + <LibraryClasses>
>> + PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>> + }
>> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
>> <LibraryClasses>
>> --
>> 1.8.3.1
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Managing the Performance of Cloud-Based Applications
>> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
>> Read the Whitepaper.
>> http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
