Thanks Olivier,
I am still defining the AMD SoC Platform Package and will
wait to see if there are any other patches that need to be considered.
Thanks for the advice, it is very much appreiciated.
BR,
Steve
On 24 February 2014 13:17, <edk2-devel-requ...@lists.sourceforge.net> wrote:
> Send edk2-devel mailing list submissions to
> edk2-devel@lists.sourceforge.net
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
> or, via email, send a message with subject or body 'help' to
> edk2-devel-requ...@lists.sourceforge.net
>
> You can reach the person managing the list at
> edk2-devel-ow...@lists.sourceforge.net
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of edk2-devel digest..."
>
>
> Today's Topics:
>
> 1. Re: [RFC] ArmPlatformPkg: PcdCPUCoreSecStackBase and
> PcdCPUCoresStackBase: UINT64 (patch) (Olivier Martin)
> 2. Re: [PATCH] OvmfPkg: implement LockBoxLib (Laszlo Ersek)
> 3. [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in
> GetAlias and SetAlias (Olivier Martin)
> 4. Re: [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in
> GetAlias and SetAlias (Olivier Martin)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 24 Feb 2014 18:40:49 -0000
> From: "Olivier Martin" <olivier.mar...@arm.com>
> Subject: Re: [edk2] [RFC] ArmPlatformPkg: PcdCPUCoreSecStackBase and
> PcdCPUCoresStackBase: UINT64 (patch)
> To: <edk2-devel@lists.sourceforge.net>
> Message-ID: <003201cf318f$f0c7e430$d257ac90$@mar...@arm.com>
> Content-Type: text/plain; charset="windows-1252"
>
> Hi Steve,
>
>
>
> I would say there is nothing wrong in your patch. Except the approach your
> are using to boot UEFI on your platform might not be appropriate. Making
> these two PCDs pointing into System Memory is not the way there are expected
> to be used.
>
>
>
> PcdCPUCoreSecStackBase and PcdCPUCoresStackBase (and SEC & PeiCore) should
> only be used when EDK2 is started in Secure World and before the (permanent)
> system memory (DRAM) is initialized.
>
> PcdCPUCoreSecStackBase should point somewhere into your Secure RAM. And
> PcdCPUCoresStackBase should point somewhere into your temporary memory (eg:
> SRAM).
>
>
>
> If your platform has a Secure/Trusted Firmware then you should not use
> ArmPlatformPkg/Sec into your UEFI firmware. Your firmware should start after
> the SEC phase.
>
> ArmPlatformPkg/Sec has been implemented to initialize the Secure World.
> Running this module in Non-Secure world is not correct.
>
> To get a proper implementation of a Trusted/Secure Firmware on ARMv8
> platform, you should have a look at the ARM Trusted Firmware Open SOurce
> project: https://github.com/ARM-software/arm-trusted-firmware
>
> If you know what you are doing and still want to use ArmPlatformPkg/Sec,
> then there is a chance your Secure RAM is into your 32bit address space
> (even if your memory map is bigger than 4GB).
>
>
>
> PEI Core is designed to start from XIP memory and used temporary memory. A
> PEIM module is expected to initialize your permanent system memory. PEI Core
> would then pass control to the DXE phase.
>
> PEI Core relocates itself from temporary memory to permanent memory during
> its execution. So starting PEI Core from permanent memory means the module
> will copy itself into permanent memory again.
>
> On most ARM Platforms, UEFI starts as a secondary stage boot loader (the
> Trusted Firmware being the first stage). To prevent this non-required copy,
> I introduced ArmPlatformPkg/PrePi that does the required PI initialization
> and pass control to the DXE core.
>
> The drawback of ArmPlatformPkg/PrePi is it does not support PEIMs. But it is
> acceptable in most cases.
>
> Again, generally your temporary memory (eg: SRAM) is in your first 4GB of
> your address space.
>
>
>
> What I want to say is - yes, there is nothing wrong to make
> PcdCPUCoreSecStackBase and PcdCPUCoresStackBase 64-bit PCDs. But the reason
> to use these PCDs might not be valid in your case.
>
> Have a look at this page for additional information:
> http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=ArmPlatformP
> kg
>
>
>
> Let me know if my email is clear enough or if you need further explanation.
> I would like to reuse the content in the wikipages.
>
>
>
> Thanks,
>
> Olivier
>
>
>
> From: Steven Kinney [mailto:steven.kin...@linaro.org]
> Sent: 21 February 2014 17:32
> To: edk2-devel@lists.sourceforge.net;
> edk2-devel-requ...@lists.sourceforge.net
> Subject: [edk2] [RFC] ArmPlatformPkg: PcdCPUCoreSecStackBase and
> PcdCPUCoresStackBase: UINT64 (patch)
>
>
>
> Hi Olivier,
>
> I modified the Stacks so that the typedef is UINT64;
> for pointing to System Memory outside of the addressable region accessable
> via UINT32. This is very similar to the System Memory changes you made
> regarding System Memory base address earlier. I can across this issue when
> migrating to our silicon memory map, which has the stacks in DRAM outside of
> the addressable range afforded by a UINT32 typedef. Please suggest changes
> or considerations I might have overlooked. I tested this on AARCH64 across
> multiple memory regions; including the RTSM SRAM locations.
>
> Thanks,
>
> Steve
> -------------- next part --------------
> An HTML attachment was scrubbed...
>
> ------------------------------
>
> Message: 2
> Date: Mon, 24 Feb 2014 19:50:22 +0100
> From: Laszlo Ersek <ler...@redhat.com>
> Subject: Re: [edk2] [PATCH] OvmfPkg: implement LockBoxLib
> To: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: edk2-devel <edk2-devel@lists.sourceforge.net>
> Message-ID: <530b946e.3070...@redhat.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> On 02/24/14 19:15, Jordan Justen wrote:
>> From: Laszlo Ersek <ler...@redhat.com>
>>
>> The S3 suspend/resume infrastructure depends on the LockBox library class.
>> The edk2 tree currently contains Null and SMM instances. The Null instance
>> is useless, and the SMM instance would require SMM emulation by including
>> the SMM core and adding several new drivers, which is deemed too complex.
>>
>> Hence add a simple LockBoxLib instance for OVMF.
>>
>> jordan.l.jus...@intel.com:
>> * use PCDs instead of EmuNvramLib
>> - clear memory in PlatformPei on non S3 boots
>> * allocate NVS memory and store a pointer to that memory
>> - reduces memory use at fixed locations
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
>> Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com>
>> ---
>>
>> Laszlo,
>>
>> I think I took nearly all of your suggestions for v4 of this
>> patch. (Which I missed for v5 of the series.)
>>
>> How does it look? Would you prefer me to bump the series
>> to v6 to send this out in that context?
>
> No, this patch implements a library; the interface is nice and explicit.
> Plus this is the only patch needing a respin, so I can review it the way
> you posted it (you've set the in-reply-to correctly, so it's showed up
> at the right spot in the series, in my edk2-devel folder).
>
> I'm adding it to my review queue.
>
> Thanks!
> Laszlo
>
>
>
> ------------------------------
>
> Message: 3
> Date: Mon, 24 Feb 2014 19:08:47 -0000
> From: "Olivier Martin" <olivier.mar...@arm.com>
> Subject: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity
> in GetAlias and SetAlias
> To: "Carsey, Jaben" <jaben.car...@intel.com>
> Cc: Brendan Jackman <brendan.jack...@arm.com>,
> edk2-devel@lists.sourceforge.net
> Message-ID: <003701cf3193$d8664bd0$8932e370$@mar...@arm.com>
> Content-Type: text/plain; charset="windows-1252"
>
> Dear ShellPkg maintainer,
>
>
>
> Please find the attached patch that makes the alias case insensitive.
>
>
>
> ShellCommandIsOnAliasList is case insensitive, but GetAlias and SetAlias use
> the UEFI variable services, which are case sensitive.
>
>
>
> Force alias names to lowercase to get around this.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Brendan Jackman <brendan.jack...@arm.com>
>
> Reviewed-By: Olivier Martin <olivier.mar...@arm.com>
>
>
>
> Best Regards,
>
> Olivier
> -------------- next part --------------
> An HTML attachment was scrubbed...
>
> ------------------------------
>
> Message: 4
> Date: Mon, 24 Feb 2014 19:17:51 -0000
> From: "Olivier Martin" <olivier.mar...@arm.com>
> Subject: Re: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case
> sensitivity in GetAlias and SetAlias
> To: <edk2-devel@lists.sourceforge.net>, "Carsey, Jaben"
> <jaben.car...@intel.com>
> Cc: Brendan Jackman <brendan.jack...@arm.com>
> Message-ID: <003c01cf3195$1ce45d50$56ad17f0$@mar...@arm.com>
> Content-Type: text/plain; charset="windows-1252"
>
> Oops forgot the attachment - thanks Jaben J
>
>
>
> From: Olivier Martin [mailto:olivier.mar...@arm.com]
> Sent: 24 February 2014 19:09
> To: Carsey, Jaben
> Cc: Brendan Jackman; edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH] ShellPkg/ShellProtocol.c: Fix case sensitivity in
> GetAlias and SetAlias
>
>
>
> Dear ShellPkg maintainer,
>
>
>
> Please find the attached patch that makes the alias case insensitive.
>
>
>
> ShellCommandIsOnAliasList is case insensitive, but GetAlias and SetAlias use
> the UEFI variable services, which are case sensitive.
>
>
>
> Force alias names to lowercase to get around this.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Brendan Jackman <brendan.jack...@arm.com>
>
> Reviewed-By: Olivier Martin <olivier.mar...@arm.com>
>
>
>
> Best Regards,
>
> Olivier
> -------------- next part --------------
> An HTML attachment was scrubbed...
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: ShellPkg-ShellProtocol.c-Fix-case-sensitivity-in-alias.patch
> Type: application/octet-stream
> Size: 5654 bytes
> Desc: not available
>
> ------------------------------
>
> ------------------------------------------------------------------------------
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
>
> ------------------------------
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
>
> End of edk2-devel Digest, Vol 50, Issue 79
> ******************************************
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
