Eric,
Sorry for confused you, the comment (I added) marked in yellow is trying to
highlight the difference between Size field of JPG block and Length field of
other image blocks.
If you see the Length field definition from EXT1 and EXT2 blocks, Length is
“Size of the image block, in byte, including the image block header”.
And the Size field of JPEG block says it is “the size of the JPEG encoded data”.
Thanks,
-Mars
寄件者: Dong, Eric [mailto:eric.d...@intel.com]
寄件日期: 2014年3月12日 下午 02:35
收件者: Mars Lin
副本: edk2-devel@lists.sourceforge.net
主旨: RE: JPEG image block parsing error in HiiDataBase.
Hi Mars,
I check the uefi spec, not found the yellow mark one, which version do you used?
Also I check the similar code in this function, like EFI_HII_IIBT_EXT1,
EFI_HII_IIBT_EXT2, they all include the size of the header. So I think current
implementation is ok.
Thanks,
Eric
From: Tian, Feng [mailto:feng.t...@intel.com]
Sent: Wednesday, March 12, 2014 11:16 AM
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: Re: [edk2] JPEG image block parsing error in HiiDataBase.
Hi, Mars
We will review this patch and get back to you if we have feedback.
Thanks
Feng
From: Mars Lin [mailto:mars_...@phoenix.com]
Sent: Wednesday, March 12, 2014 11:05
To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: [edk2] 回覆: JPEG image block parsing error in HiiDataBase.
Hi Feng,
Any update for this proposed change to MdeModulePkg?
Thanks,
-Mars
寄件者: Mars Lin [mailto:mars_...@phoenix.com]
寄件日期: 2014年2月19日 下午 02:27
收件者: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
主旨: [edk2] JPEG image block parsing error in HiiDataBase.
Dear MdeModulePkg maintainers,
Please consider attached patch file for fixing wrong JPEG image block traverse
error.
Summary
A true-color bitmap is encoded with JPEG image compression.
Prototype
#define EFI_HII_IIBT_IMAGE_JPEG 0x18
typedef struct _EFI_HII_IIBT_JPEG_BLOCK {
EFI_HII_IMAGE_BLOCK Header;
UINT32 Size;
UINT8 Data[ … ];
} EFI_HII_IIBT_JPEG;
Members
Header Standard image header, where Header.BlockType = EFI_HII_IIBT_IMAGE_JPEG.
Size Specifies the size of the JPEG encoded data. (Not include size of Header)
Data JPEG encoded data with ‘JFIF’ signature at offset 6 in the data block.
The JPEG encoded data, specifies type of encoding and final size of true-color
image.
[Path] MdeModulePkg\Universal\HiiDatabaseDxe\Image.c
[Function] GetImageIdOrAddress
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Smith Cheng
<smith_ch...@phoenix.com<mailto:smith_ch...@phoenix.com>>
Regards,
-Mars
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
