On 04/04/14 10:28, Jordan Justen wrote: > On Fri, Apr 4, 2014 at 6:07 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > I think that Reza's fix is correct, I'd just put the > > statement right at the top of the constructor, instead of pushing it > >down to CVfrCompiler::OptionInitialization(). you're right i fixed this, the change is now in the constructor > > Even if the fix is correct, the we can't do anything with it, since it > was not submitted with Contributed-under. > > At the very least, Contributed-under is required, but an actual commit > message would be good too. :) I've been meaning to this. Also, I need to submit this to the basetool-devel mailing list correct?
On 04/04/14 20:01, Laszlo Ersek wrote: > Also, I tried to grep the BaseTools subtree for such a > constructor-initializer (for a pattern like "right paren followed by > whitespace followed by colon"), and I found nothing relevant. this is actually one of the odder things, because the exact same code works fine on an older ubuntu release. same compiler version and all. ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
