I am a bit confused by one of the comment in
MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c.

The comment at line 480
(https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Consol
e/GraphicsConsoleDxe/GraphicsConsole.c#L480) is:

 

        //

        // if not supporting current mode, try 800x600 which is required by
UEFI/EFI spec

        //

        Status = CheckModeSupported (

                     Private->GraphicsOutput,

                     800,

                     600,

                     &ModeNumber

                     );

 

I can see a requirement on 80x25 in 11.4 Simple Text Output Protocol but I
have not found the requirement on 800 x 600.

I might have done a search on the wrong keywords (I tried '600' and VGA).

 

There is a similar comment at line 527
(https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Universal/Consol
e/GraphicsConsoleDxe/GraphicsConsole.c#L527).

 

If the comments are wrong then 800x600 should maybe be replaced by PcdGet32
(PcdVideoHorizontalResolution)x PcdGet32 (PcdVideoVerticalResolution).

 
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their 
applications. Written by three acclaimed leaders in the field, 
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to