Il 24/06/2014 22:27, Laszlo Ersek ha scritto: > - (minor nit) I suggested MdePkg.dec, not MdePkg.dsc, but I guess their > availability is interchangeable for this purpose, so OK;
Heh I didn't remember exactly which one you suggested and didn't have network access when I wrote the patch. :) > - more importantly, since the user is requested to source "edksetup.sh" > rather than execute it in a subshell, I think the above code (although > exiting with status 1) can introduce an incorrect WORKSPACE variable to > the user's environment. In addition, I think BuildEnv can capture that > incorrect WORKSPACE in a few other places too. Hmm, you're right. > What is the reason for not doing the workspace sanity check before > sourcing BuildEnv? In BuildEnv this sanity check used to be an early step. > > ScriptMain > SetWorkspace > check for already set WORKSPACE > if unset or empty, verify edk2 root > > Ah, I think I understand. You don't want to duplicate (or exploit) > BuildEnv's > > export WORKSPACE=`pwd` > > logic in edksetup.sh. Namely, if you wanted to check in advance, before > calling BuildEnv, you'd have to know where BuildEnv itself would check > (ie. know that BuildEnv would assign WORKSPACE the cwd). Yes. > Not sure what to suggest. It's either duplicating this knowledge in > edksetup.sh, or rolling back all of BuildEnv's changes, or leaving the > check in BuildEnv's SetWorkspace (just with a different implementation, > ie. looking for MdePkg). I will just duplicate BuildEnv's SetWorkspace here. It's okay, because then BuildEnv's SetWorkspace will find [ -n "$WORKSPACE ] and do nothing. Paolo ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
