Il 27/06/2014 19:16, Jordan Justen ha scritto: > On Thu, Jun 26, 2014 at 2:33 PM, Paolo Bonzini <[email protected]> wrote: >> Il 25/06/2014 22:12, Jordan Justen ha scritto: >>>>> >>>>> At least EfiRom is generic and not only of use during an edk2 build. I >>>>> suppose others could be useful (such as PatchPcdValue or VolInfo). >>> I think all these tools are too generically named to be installed in >>> the main bin path. (Even if they don't happen to conflict with any >>> other commands.) >>> >>> I still think access to these tools would be better as: >>> $ edk2 build >>> $ edk2 EfiRom >>> $ edk2 VolInfo >> >> I think a middle ground could be: >> >> - the few generically useful tools stay in /usr/bin >> >> - the others move to /usr/libexec/edk2, including build > > How about move them all, but symlink EfiRom?
Sure. > VolInfo once again seems like too generic of a name for /usr/bin, but > it is only useful outside of the build. What about PatchPcdValue? >> - tools are modified to look for Conf/ in EDK_TOOLS_PATH before WORKSPACE. > > I think $WORKSPACE/Conf needs to be checked first to allow the user to > override the defaults. Yes, you're right. >> - /usr/bin/edk2-build is a wrapper that adds /usr/libexec/edk2 to PATH, >> sets WORKSPACE to `pwd`, EDK_TOOLS_PATH to /usr/share/edk2, and invokes >> /usr/libexec/edk2/build > > I guess I was leaning a bit towards the single edk2 command with > sub-commands, but it is not a big deal to me. A generic edk2 command would be okay, but do you really need anything except build? (And EfiRom, which we need to keep in /usr/bin for backwards compatibility). Ok to apply the patches, since they work for all packaging scenarios? Paolo > -Jordan > >> IIUC these two patches would work fine for the above case, for the >> current Fedora packaging (/usr/bin + /usr/share/edk2) and also for the >> case where: >> >> - BaseTools/ is installed in /opt/edk2 >> >> - Binaries are invoked via /opt/edk2/BinWrappers/Linux-x86_64 (or >> similar) which BuildEnv already sets correctly >> >> - BuildEnv is patched with "BuildEnv: remove useless check before >> setting $WORKSPACE" >> >> - The user still has to point EDK_TOOLS_PATH to /opt/edk2 >> >> So they seem overall they are independent from the details of the >> packaging. Is this correct? >> >> Paolo >> >> ------------------------------------------------------------------------------ >> Open source business process management suite built on Java and Eclipse >> Turn processes into business applications with Bonita BPM Community Edition >> Quickly connect people, data, and systems into organized workflows >> Winner of BOSSIE, CODIE, OW2 and Gartner awards >> http://p.sf.net/sfu/Bonitasoft >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
