Code style suggestion: Status = gBS->AllocatePool( EfiLoaderData, NodeSize, (void**)&Head); => Status = gBS->AllocatePool (EfiLoaderData, NodeSize, (void**) &Head);
Reviewed-by: Jordan Justen <[email protected]> On 2014-07-24 14:06:52, Mcdaniel, Daryl wrote: > Jaben, Stefan: could you please review the attached change? Both patch > format and full file are attached. > > > > StdLib/LibC/StdLib/Malloc.c: Revert cast removal to fix GCC build > breakage. > > > > The cast to (void**) is needed for the last parameter of the AllocatePool > call in malloc(). This is because type CPOOL_HEAD** is not automatically > promoted to void**, as required by AllocatePool(). > > > > This was originally addressed in SVN revision 15474 but removed again in > 15664. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Daryl McDaniel <[email protected]> > > Reviewed by: ... > > > > > > Daryl McDaniel
signature.asc
Description: signature
------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds
_______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
