Jaben,
Your fix is right. I also checked terminal console driver, its
SetAttribute has no such problem.
Reviewed-by: Elvin Li
<[email protected]<mailto:[email protected]>>
Thanks
Elvin
From: Carsey, Jaben [mailto:[email protected]]
Sent: Friday, July 25, 2014 6:59 AM
To: Bjorge, Erik C; Kinney, Michael D
Cc: [email protected]
Subject: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute
Erik & Mike,
Can you please check this? I found this during debug and I realize that this
is not verifying the correct number of bits. I need to get an error when the
8th bit being set.
Reference from UEFI 2.4B SetAttribute() API:
Attribute The attribute to set.
Bits 0..3 are the foreground color, and bits 4..6 are the background color.
All other bits are reserved. See "Related Definitions" below.
MdeModulePkg: Fix parameter verification for SetAttribute
Check for 8th bit being reserved as per UEFI spec.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
