Jaben,
Thanks for all the reviews.
Similar to my response for the 'devices' change. The 'memmap' example output
in the shell spec is just an example. Implementations can decide what and how
to display.
For servers with large amounts of memory, we found that there needed to be
additional output alignment to make 'memmap' summary easier to read. It also
made sense to add additional memory types to the summary.
Thanks,
Chris
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Thursday, August 21, 2014 3:27 PM
To: Phillips, Chris J (Plano, TX); edk2-devel@lists.sourceforge.net
Cc: Carsey, Jaben
Subject: RE: ShellPkg: Fixes and updates for the 'memmap' command
Reviewed-by: Jaben Carsey
<jaben.car...@intel.com<mailto:jaben.car...@intel.com>>
15872
I notice that neither the old non-SFO summary table nor this one is actually
the same as the spec example. The old summary had more info than that and the
new one has even more, but it has the same as the SFO more, which makes sense.
Just something to think on.
reserved : 512 Pages (2,097,152)
LoaderCode: 98 Pages (401,408)
LoaderData: 32 Pages (131,072)
BS_code : 335 Pages (1,372,160)
BS_data : 267 Pages (1,093,632)
RT_data : 19 Pages (77,824)
available : 4,369 Pages (17,895,424)
Total Memory: 20 MB (20,971,520) Bytes
From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com]
Sent: Wednesday, August 20, 2014 2:51 PM
To: Carsey, Jaben;
edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net>
Subject: ShellPkg: Fixes and updates for the 'memmap' command
Importance: High
Please review the attached patch. I'm also including the .uni file.
Thanks,
Chris
ShellPkg: Fixes and updates for the 'memmap' command
- Update 'memmap -sfo' format to match UEFI Shell 2.1 spec
- Update help output for easier viewing
- Update 'memmap' output format for better alignment
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chr...@hp.com<mailto:chr...@hp.com>>
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
