I am not sure the BaseTools has already raised a warning/error on multiple
PCD definitions.

In our build system, it automatically appends
'gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString' at the end of the
DSC file to track the built binaries.

And I have not seen any issue in case PcdFirmwareVersionString was already
defined.

 

From: El-Haj-Mahmoud, Samer [mailto:[email protected]] 
Sent: 25 August 2014 18:59
To: [email protected]
Subject: [edk2] Duplicate PCDs in DSC files

 

It looks like the build tools will not warn you (or stop with an error) if
there are multiple declarations of the same PCD in the DSC file. In fact,
the same PCD could be initialized multiple times using different values and
different types (Fixed vs. Dynamic for instance), and the build tools will
silently pick the last instance of the PCD in the DSC File.

 

We just finished debugging a nasty issue caused by duplicate PCDs, and it
would have been nice to prevent this to begin with! Looks to me like a bug
in the tool.

 

Can we add the ability to break the build if there are duplicate PCD
instances in the DSC file?

 

 

 


Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers 

 <mailto:[email protected]> [email protected] 
T +1.281.514.5973

C +1.512.659.1523
Hewlett-Packard Company
 <http://hp.com/go/proliant/uefi> hp.com/go/proliant/uefi

Description: Description: C:\Users\elhajmah\HpLogo.png

 
------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to