Liming,
Looks good.
Reviewed-by: Andrew Fish <af...@apple.com>
On Sep 4, 2014, at 7:28 PM, Gao, Liming <liming....@intel.com> wrote:
> Andrew:
> Could you help review this patch?
>
> MdeModulePkg: Fix XCODE Link Issue in DxeCore
>
> In XCODE tool chain, the 64-bit bit wise and operation is causing the
> compiler to emit an __umoddi3.
> This patch uses BaseLib API to replace 64-bit bit operation.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gao, Liming <liming....@intel.com>
> CC: af...@apple.com
>
> Index: Stall.c
> ===================================================================
> --- Stall.c (revision 15972)
> +++ Stall.c (working copy)
> @@ -32,7 +32,7 @@
> IN UINT64 Counter
> )
> {
> - while ((Counter & 0xffffffff00000000ULL) != 0) {
> + while (RShiftU64 (Counter, 32) > 0) {
> gMetronome->WaitForTick (gMetronome, 0xffffffff);
> Counter -= 0xffffffff;
> }
>
> Thanks
> Liming
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
