Reviewed-by: Jaben Carsey <[email protected]>
From: Bjorge, Erik C
Sent: Wednesday, September 10, 2014 5:44 PM
To: [email protected]; Mcdaniel, Daryl; Carsey, Jaben
Subject: RE: [PATCH] StdLib: Fix some build problems and obscure bugs.
Importance: High
Reviewed-by: Erik Bjorge
<[email protected]<mailto:[email protected]>>
From: Bjorge, Erik C [mailto:[email protected]]
Sent: Wednesday, September 10, 2014 1:13 PM
To: Mcdaniel, Daryl;
[email protected]<mailto:[email protected]>;
Carsey, Jaben
Subject: Re: [edk2] [PATCH] StdLib: Fix some build problems and obscure bugs.
Changes look fine other than the addition of end-of-line comments. Any
particular reason for this comment style change? We are specifically talking
about the changes in Fifo.c.
-Erik/Jaben
From: Mcdaniel, Daryl
Sent: Tuesday, September 09, 2014 4:24 PM
To: [email protected]<mailto:[email protected]>;
Bjorge, Erik C; Carsey, Jaben
Subject: [PATCH] StdLib: Fix some build problems and obscure bugs.
Erik, Jaben; Could you please review the attached patches?
StdLib: Fix some build problems and obscure bugs.
StdLib\
BsdSocketLib\
ns_print.c
Use "%lu" format instead of "%Lu". A capital 'L' specifies (long double)
in print formats.
Add a cast from char to (unsigned int) to match its sprintf format.
res_debug.c
Use "%lu" format instead of "%Lu". A capital 'L' specifies (long double)
in print formats.
EfiSocketLib\
Socket.c
Update copyright & correct formatting
Include\
sys\
EfiCdefs.h
Update copyright date
Change type of LONGN and ULONGN to INTN and UINTN, respectively.
errno.h
Update copyright date
Add enum member '__ESUCCESS = 0'
fcntl.h
Update copyright date
Improve comment for O_EXCL
stat.h
Update copyright date
Reorder the S_* flags
Put the S_* predicate macros in the same order as their flag definitions
Add a function header comment to the stat() function declaration.
errno.h
Update copyright date
Define new ESUCCESS error code
wchar.h
Update copyright date
Correct the description of the Nptr parameter to the wcstol, wcstoll,
wcstoul, and wcstoull functions.
x86\float.h
Update copyright date
Define 'long double' limits for non-Microsoft compilers
LibC\
Containers\Queues\Fifo.c
Rewrite to make more robust and secure (zeros out old data)
StdLib\realpath.c
Update copyright date
Reformat descriptive comment for realpath()
Add terminating CRLF
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: [email protected]<mailto:[email protected]>
Reviewed-by:
Thanks,
Daryl McDaniel
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
