On Thu, Sep 11, 2014 at 2:43 AM, Chen, Fan <[email protected]> wrote: > On Thu, 2014-09-11 at 07:36 +0000, Fan, Jeff wrote: >> > 5. Please follow EDKII coding style document to add function headers >> > and refine your code. Please refer to >> > https://sourceforge.net/projects/edk2/files/General%20Documentation/ED >> > K%20II%20C%20Coding%20Standards%20Specification.pdf/download >> > >> >> You might want to point out a coding style concern you noticed for Chen. >> [Jeff] Yes. To let the code meet EDKII check-in criteria.
Jeff, I meant maybe you could reply to a patch where you see an issue and point it out to Chen. (I don't think you have to do this for all patches since Chen will then be able to apply the feedback to all of his patches.) > [Chen] Ok, I will learn them ASAP. ;) This page might help for a quick overview: https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C -Jordan ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
