On Thu, Sep 11, 2014 at 11:07 PM, Nikolai Saoukh <[email protected]> wrote: > On Fri, Sep 12, 2014 at 9:45 AM, Jordan Justen <[email protected]> wrote: >> I think this may have been the 3rd time someone submitted this. (And, >> this goes way back...) :( >> >> The reason I think it was added this way originally is that someone >> was using CYGWIN on Windows. That has also been the hangup for not >> fixing it in the past. Concern about what it *might* break. > > I was under impression that forward slash (/) accepted as file separator in > ms windows world even by cygwin.
It is possible. The point is, when they added it, (I assume) it worked, so I think they were on Windows. I tried asking if anyone could test this change on CYGWIN in the past, but no one spoke up. Then we forgot about it... Anyway, I think at this point we should just make the change. If it breaks something, maybe then they'll speak up. :) This seems to be the original commit from October 2011: https://github.com/tianocore/buildtools-BaseTools/commit/b377180a I notice before the change we were using the (+) macro in build_rule which generates the proper path separator based on the system. I don't think (+) is available in tools_def. -Jordan ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
