Hi, Sava Agree. I also correct the return status when time out happens to avoid return EFI_SUCCESS.
Please review again. Thanks Feng From: A. Sava [mailto:asava....@gmail.com] Sent: Saturday, September 13, 2014 00:34 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH v2 1/6] MdeModulePkg: Check D2H register status in AhciPioTransfer Hi again Feng, After a more careful examination, there is a problem with your latest patch. When FIS is received and D2H is not received, Status remains set to EFI_ERROR, due to the D2H check which comes after the FIS check. Cheers, A. Sava On Tue, Sep 2, 2014 at 3:30 PM, Reza Jelveh <reza.jel...@tuhh.de<mailto:reza.jel...@tuhh.de>> wrote: On 02/09/14 05:21, Tian, Feng wrote: > Hi, Sava > > From my side, I am ok with integrating these two cases into one. > > Please help review and verify if the attached patch is ok for Qemu and > Marvel’s AHCI controller. > Looks good from my side. Agreed with the comment issue. ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/edk2-devel
AhciMode2.c.patch
Description: AhciMode2.c.patch
------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
