On 01/12/15 20:17, Olivier Martin wrote: > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec can also be removed from > ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/PlatformInte > lBdsLib.inf.
It can't. In "ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.h", we have the following two includes: #include <Library/GenericBdsLib.h> #include <Library/PlatformBdsLib.h> -> IntelFrameworkModulePkg/Include/Library/GenericBdsLib.h IntelFrameworkModulePkg/Include/Library/PlatformBdsLib.h The former provides typedefs like BDS_COMMON_OPTION, which is used in "ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c". The latter provides prototypes for functions like PlatformBdsBootSuccess() and PlatformBdsPolicyBehavior(), which the same C file implements. > Reviewed-By: Olivier Martin <[email protected]> Thank you! I'll await Jordan's ACK as well. Laszlo > > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:[email protected]] >> Sent: 07 January 2015 11:43 >> To: [email protected] >> Subject: [edk2] [PATCH 3/3] ArmVirtualizationPkg: PlatformIntelBdsLib: >> get front page timeout from QEMU >> >> Put QemuBootOrderLib's GetFrontPageTimeoutFromQemu() to use, so that >> ArmVirtualizationPkg's Platform BDS policy can consume QEMU's command >> line >> option >> >> -boot menu=on,splash-time=N >> >> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1172756 >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <[email protected]> >> --- >> >> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Platfor >> mIntelBdsLib.inf | 2 -- >> >> ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/IntelBd >> sPlatform.c | 18 +----------------- >> 2 files changed, 1 insertion(+), 19 deletions(-) >> >> diff --git >> a/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Platf >> ormIntelBdsLib.inf >> b/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Platf >> ormIntelBdsLib.inf >> index 8db2ad5..6542705 100644 >> --- >> a/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Platf >> ormIntelBdsLib.inf >> +++ >> b/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Platf >> ormIntelBdsLib.inf >> @@ -22,7 +22,6 @@ >> MODULE_TYPE = DXE_DRIVER >> VERSION_STRING = 1.0 >> LIBRARY_CLASS = PlatformBdsLib|DXE_DRIVER >> - CONSTRUCTOR = PlatformIntelBdsConstructor >> >> # >> # The following information is for reference only and not required by >> the build tools. >> @@ -67,7 +66,6 @@ >> [Pcd] >> gArmPlatformTokenSpaceGuid.PcdDefaultConInPaths >> gArmPlatformTokenSpaceGuid.PcdDefaultConOutPaths >> - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdPlatformBootTimeOut >> >> [Protocols] >> gEfiDevicePathFromTextProtocolGuid >> diff --git >> a/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Intel >> BdsPlatform.c >> b/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Intel >> BdsPlatform.c >> index 6fea2b0..a03e909 100644 >> --- >> a/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Intel >> BdsPlatform.c >> +++ >> b/ArmPlatformPkg/ArmVirtualizationPkg/Library/PlatformIntelBdsLib/Intel >> BdsPlatform.c >> @@ -17,22 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, >> EITHER EXPRESS OR IMPLIED. >> >> #include <Library/QemuBootOrderLib.h> >> >> -/// >> -/// Predefined platform default time out value >> -/// >> -UINT16 gPlatformBootTimeOutDefault; >> - >> -EFI_STATUS >> -EFIAPI >> -PlatformIntelBdsConstructor ( >> - IN EFI_HANDLE ImageHandle, >> - IN EFI_SYSTEM_TABLE *SystemTable >> - ) >> -{ >> - gPlatformBootTimeOutDefault = (UINT16)PcdGet16 >> (PcdPlatformBootTimeOut); >> - return EFI_SUCCESS; >> -} >> - >> // >> // BDS Platform Functions >> // >> @@ -320,7 +304,7 @@ PlatformBdsPolicyBehavior ( >> // >> BdsLibBuildOptionFromVar (BootOptionList, L"BootOrder"); >> >> - PlatformBdsEnterFrontPage (gPlatformBootTimeOutDefault, TRUE); >> + PlatformBdsEnterFrontPage (GetFrontPageTimeoutFromQemu(), TRUE); >> } >> >> /** >> -- >> 1.8.3.1 >> >> >> ----------------------------------------------------------------------- >> ------- >> Dive into the World of Parallel Programming! The Go Parallel Website, >> sponsored by Intel and developed in partnership with Slashdot Media, is >> your >> hub for all things parallel software development, from weekly thought >> leadership blogs to news, videos, case studies, tutorials and more. >> Take a >> look and join the conversation now. http://goparallel.sourceforge.net >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > > > ------------------------------------------------------------------------------ > New Year. New Location. New Benefits. New Data Center in Ashburn, VA. > GigeNET is offering a free month of service with a new server in Ashburn. > Choose from 2 high performing configs, both with 100TB of bandwidth. > Higher redundancy.Lower latency.Increased capacity.Completely compliant. > www.gigenet.com > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. www.gigenet.com _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
