On 01/12/15 23:29, Jordan Justen wrote: > On 2015-01-12 13:06:31, Laszlo Ersek wrote: >> On 01/12/15 21:53, Jordan Justen wrote: >>> On 2015-01-07 03:42:47, Laszlo Ersek wrote: >>>> + // >>>> + // SeaBIOS default if the user didn't state a timeout. >>>> + // >>>> + TimeoutMs = 2500; >>> >>> I think we should return PcdPlatformBootTimeOut in this case. >> >> Just so I understand you correctly: >> * '-boot menu=off' or (equivalently) no '-boot menu=ZZZ' option at all: >> return PcdPlatformBootTimeOut (which is currently 0 for OVMF, after >> earlier discussions) >> * '-boot menu=on,splash-time=N': wait for N msecs, rounder up to seconds >> * '-boot menu=on', *without* 'splash-time=N': patch currently uses >> SeaBIOS default (2500 msecs rounded up to 3 seconds), but you're >> saying we should return PcdPlatformBootTimeOut instead. >> >> Re #3, since that PCD is 0 in OVMF (based on earlier agreement), this >> suggestion boils down to '-boot menu=off' and '-boot menu=on' being >> indistinguishable. Slightly rephrased, '-boot menu=on' without >> 'splash-time=N' would have no visible effect. > > Ah. No, you are right. > > For the comment above, how about instead of 'SeaBIOS default...' you > could say that this is the default in the case that menu=on is > specified, but splash-time is not? > > And, perhaps mention it in the commit message? > > Regarding the 2500 constant, it seems fine. With EDK II, we always > seem to think about PCDs, but I don't think it is required here... > > Hmm, I guess you could use PcdPlatformBootTimeOut as the default if it > is non-zero, but if it is 0 use the hard-coded 2500 value.
Good idea, thanks! Laszlo ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
