On 02/08/15 00:55, Gabriel L. Somlo wrote: > Hi Jordan, > > On Sat, Feb 07, 2015 at 03:12:26PM -0800, Jordan Justen wrote: >> On 2015-02-07 08:26:39, Laszlo Ersek wrote: >>> On 02/06/15 21:57, Gabriel L. Somlo wrote: >>>> Insert a default, OVMF-specific Type 0 (BIOS Information) structure >>>> into the SMBIOS table, unless the underlying guest VM supplies its >>>> own, overriding instance. >>>> >>>> As an example, QEMU, while allowing the user to specifically force >>>> generation of a Type 0 structure, will not generate one by default, >>>> considering that task to be the responsibility of the BIOS itself. >>>> >>>> Based on an earlier out-of-tree patch by Laszlo Ersek <[email protected]> >>> >>> I'll let Jordan review this one. >> >> It looks good. Does this need Contributed-under and Signed-off-by from >> Laszlo too? > > Laszlo came up with the awesomely clever way to statically initialize > a SMBIOS structure, complete with unformatted trailing text strings ! > > So I lifted his Type0 definition, polished it a bit, and added the > logic deciding whether it needs to be inserted into the table or not. > > As for exactly how we acknowledge that, I'm really too new at this to > have an informed opinion -- whatever you all end up deciding is completely > fine by me !
I'm fine with the credit given in the commit message body. Thanks! Laszlo ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
