David,
I have checked in the update at edk2 17130 and 17131. I look forward to
your 2nd part of update to support HiPermanentMemoryAddress/
HiPermanentMemorySize.
Regards
Elvin Li
-----Original Message-----
From: Li, Elvin [mailto:[email protected]]
Sent: Saturday, April 04, 2015 8:52 PM
To: David Woodhouse
Cc: [email protected]; De, Debkumar
Subject: Re: [edk2] LegacyBios: Update EFI_COMPATIBILITY16_TABLE to match 0.98
CSM spec update
OK. For your first patch, it is good to me.
Reviewed-by: Elvin Li <[email protected]>
Thanks
Elvin Li
-----Original Message-----
From: David Woodhouse [mailto:[email protected]]
Sent: Saturday, April 4, 2015 1:29 PM
To: Li, Elvin
Cc: De, Debkumar; [email protected]; Ni, Ruiyu; Tian, Hot
Subject: Re: LegacyBios: Update EFI_COMPATIBILITY16_TABLE to match 0.98 CSM
spec update
On Sat, 2015-04-04 at 04:29 +0000, Li, Elvin wrote:
> David,
> Yes, it is worth! Could you send the full patch now? We could
> review it now and then check in as long as it is good. Thank you for
> support.
It's poor engineering practice to make two functional changes within a single
patch, although I appreciate that legacy version control systems tend to
encourage that misbehaviour.
Once the first patch is applied and implements UmaAddress/UmaAddress handling,
I'll follow up with the second.
--
dwmw2
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
