Maybe my description not clear, this means the first time display engine process the form which need to be show.
Thanks, Eric -----Original Message----- From: Justen, Jordan L Sent: Monday, April 20, 2015 3:20 PM To: Dong, Eric; Gao, Liming Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] MdeModulePkg/SetupBrowserDxe: Assert after mismatch dialog popup >From the patch: + // + // First enter to show the menu, update highlight info. + // I don't understand this comment. Does it mean this? "This is the first time we showed the menu, so we need to update the highlight info." The commit message below doesn't mention "first", so I think maybe I'm misunderstanding. On 2015-04-17 00:09:55, Dong, Eric wrote: > Hi Liming, > > Please find the attached patch: I think if you add someone to the 'To' or 'Cc' when sending a patch, then they can see that you want to grab their attention. So, you don't need to bother to add a special message asking them to review it, because they will see that it is a patch, and they have been Cc'd on the patch. We do have this documented a little in the edk2/Maintainers.txt file: "You should email the edk2-devel list, but you can also Cc the maintainer." So, the simple process would be, email the patch to edk2-devel, but add Cc's for others if you like. If you use git, and include a Cc line in the commit message, then git send-email will automatically do this. -Jordan > In normal case, display engine will check the environment before display > one form. After display one form, it will update the environment again. In > this case, when ordered list opcode has mismatch error, display engine > will exit from current display process. It will not update the environment > variable. Later when display engine paint the form again, it failed to > check the environment and the assert raised. Now update the logic, after > check the environment, calculate the new parameter and update it. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Eric Dong <eric.d...@intel.com> > > Thanks, > > Eric > > ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
