Good suggestion! I would choose: -- If an error would be returned, then the function will also ASSERT().
Thank you Yao Jiewen -----Original Message----- From: Justen, Jordan L Sent: Tuesday, May 05, 2015 1:10 PM To: [email protected]; Yao, Jiewen Subject: Re: [edk2] [patch] MdePkg: add comment for SafeString API in BaseLib Rather than: If error value would be returned, the function will ASSERT() also. I think this sounds better: If an error would be returned, then the function will also ASSERT(). Or, possibly: If an error would be returned, then the function will also trigger an ASSERT(). -Jordan On 2015-05-04 20:51:51, Yao, Jiewen wrote: > Thanks to feedback from Jaben. > > I updated the comments. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: "Yao, Jiewen" <[email protected]> > > Reviewed-by: "Carsey, Jaben" <[email protected]> > > > > From: Yao, Jiewen > Sent: Tuesday, May 05, 2015 10:44 AM > To: [email protected] > Subject: [edk2] [patch] MdePkg: add comment for SafeString API in > BaseLib > > > > Hi > > Here is patch to add comment for SafeString API in BaseLib for MdePkg. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: "Yao, Jiewen" <[email protected]> > > > > Thank you > > Yao Jiewen > > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
