On 2015-05-12 00:00:20, Wei, David wrote: > Shifei please subscribe through > https://lists.sourceforge.net/lists/listinfo/edk2-devel. > Then resend the patch to review. Please do not include any > individuals' mail address in the CC list or To list.
I think it is okay to Cc on patches. With git, it is useful to add Cc email addesses to the commit message for a patch to help get someone's attention to look at the patch. Then 'git send-email' will automatically Cc them when the patch is sent. -Jordan > -----Original Message----- > From: Justen, Jordan L > Sent: Tuesday, May 12, 2015 11:55 AM > To: edk2-devel@lists.sourceforge.net; Wei, David; Lu, ShifeiX A > Cc: He, Tim; Wu, Mike; Guo, Mang > Subject: Re: [edk2] [Patch] Vlv2TbltDevicePkg:Fixed SOURCE_DEBUG_ENABLE build > error > > On 2015-05-11 02:06:44, Wei, David wrote: > > It looks good. > > What looks good? I don't think Shifei is subscribed to edk2-devel because the > original post did not go through. > > -Jordan > > > Reviewed-by: David Wei <david....@intel.com> > > > > > > > > Thanks, > > > > David | SSG BIOS > > > > > > > > From: Lu, ShifeiX A > > Sent: Monday, May 11, 2015 5:03 PM > > To: 'edk2-devel@lists.sourceforge.net' > > Cc: Wei, David; He, Tim; Wu, Mike; Guo, Mang; Lu, ShifeiX A > > Subject: [edk2][Patch] Vlv2TbltDevicePkg:Fixed SOURCE_DEBUG_ENABLE build > > error > > > > > > > > Fixed SOURCE_DEBUG_ENABLE build error. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Signed-off-by: Lu, ShifeiX A <shifeix.a...@intel.com> > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > Shifei > > > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
