On 05/13/15 22:46, Gabriel L. Somlo wrote: > Hi, > > I build OVMF using > > build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc > > As of commit 87bfeb11f84dd1d369bb2e195ef83d20b0d80d61 (svn 17428), I > started getting the error below. Apparently GCC cares about the > difference between UINT8* and CHAR8* when calling AsciiStrCmp(). > > Thanks much (and sorry about the dupe if this is already a known issue).
Sent a fix for it yesterday: http://article.gmane.org/gmane.comp.bios.tianocore.devel/14600 Eric reviewed it: http://article.gmane.org/gmane.comp.bios.tianocore.devel/14626 He also committed it as SVN r17445. Thanks Laszlo > > --Gabriel > > > "/usr/bin/gcc" -g -fshort-wchar -fno-strict-aliasing -Wall -Werror > -Wno-array-bounds -ffunction-sections -fdata-sections -c -include > AutoGen.h -DSTRING_ARRAY_NAME=HiiDatabaseStrings -m64 > -fno-stack-protector "-DEFIAPI=__attribute__((ms_abi))" > -DNO_BUILTIN_VA_FUNCS -mno-red-zone -Wno-address -mcmodel=large > -Wno-address -Wno-unused-but-set-variable -mno-mmx -mno-sse -o > /home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe/OUTPUT/./ConfigKeywordHandler.obj > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe > -I/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe/DEBUG > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/X64 > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg > -I/home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Include > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c: > In function ‘GetStringIdFromString’: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:809:42: > error: pointer targets in passing argument 2 of ‘AsciiStrCmp’ differ > in signedness [-Werror=pointer-sign] > if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) { > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1175:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrCmp ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:819:42: > error: pointer targets in passing argument 2 of ‘AsciiStrCmp’ differ > in signedness [-Werror=pointer-sign] > if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) { > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1175:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrCmp ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:834:44: > error: pointer targets in passing argument 2 of ‘AsciiStrCmp’ differ > in signedness [-Werror=pointer-sign] > if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) { > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1175:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrCmp ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:854:44: > error: pointer targets in passing argument 2 of ‘AsciiStrCmp’ differ > in signedness [-Werror=pointer-sign] > if (AsciiStrCmp(AsciiKeywordValue, StringTextPtr) == 0) { > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1175:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrCmp ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c: > In function ‘GetNextStringId’: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1072:30: > error: pointer targets in passing argument 1 of ‘AsciiStrToUnicodeStr’ > differ in signedness [-Werror=pointer-sign] > AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue); > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1560:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrToUnicodeStr ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1091:30: > error: pointer targets in passing argument 1 of ‘AsciiStrToUnicodeStr’ > differ in signedness [-Werror=pointer-sign] > AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue); > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1560:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrToUnicodeStr ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1112:32: > error: pointer targets in passing argument 1 of ‘AsciiStrToUnicodeStr’ > differ in signedness [-Werror=pointer-sign] > AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue); > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1560:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrToUnicodeStr ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1139:32: > error: pointer targets in passing argument 1 of ‘AsciiStrToUnicodeStr’ > differ in signedness [-Werror=pointer-sign] > AsciiStrToUnicodeStr(StringTextPtr, *KeywordValue); > ^ > In file included from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.h:38:0, > from > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:16: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdePkg/Include/Library/BaseLib.h:1560:1: > note: expected ‘const CHAR8 *’ but argument is of type ‘UINT8 *’ > AsciiStrToUnicodeStr ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c: > In function ‘ConstructConfigHdr’: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1677:15: > error: pointer targets in assignment differ in signedness > [-Werror=pointer-sign] > AsciiName = ((EFI_IFR_VARSTORE *) OpCodeData)->Name; > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1687:15: > error: pointer targets in assignment differ in signedness > [-Werror=pointer-sign] > AsciiName = ((EFI_IFR_VARSTORE_EFI *) OpCodeData)->Name; > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c: > In function ‘EnumerateAllKeywords’: > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:2636:72: > error: passing argument 3 of ‘ExtractConfigRequest’ from incompatible > pointer type [-Werror] > Status = ExtractConfigRequest (DataBaseRecord, > NextStringId, &OpCode, &ConfigRequest); > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:1974:1: > note: expected ‘UINT8 **’ but argument is of type ‘CHAR8 **’ > ExtractConfigRequest ( > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:2664:48: > error: pointer targets in passing argument 1 of > ‘ExtractReadOnlyFromOpCode’ differ in signedness > [-Werror=pointer-sign] > ReadOnly = ExtractReadOnlyFromOpCode(OpCode); > ^ > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c:503:1: > note: expected ‘UINT8 *’ but argument is of type ‘CHAR8 *’ > ExtractReadOnlyFromOpCode ( > ^ > cc1: all warnings being treated as errors > GNUmakefile:418: recipe for target > '/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe/OUTPUT/ConfigKeywordHandler.obj' > failed > make: *** > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe/OUTPUT/ConfigKeywordHandler.obj] > Error 1 > > > build.py... > : error 7000: Failed to execute command > make tbuild > [/home/somlo/KVM-OSX/SCRATCH/edk2/Build/OvmfX64/DEBUG_GCC49/X64/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe] > > > build.py... > : error F002: Failed to build module > > /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > [X64, GCC49, DEBUG] > > - Failed - > Build end time: 16:23:30, May.13 2015 > Build total time: 00:01:14 > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
