Hi, Jordan, Thank you for these recommendations. Guo, Could you please follow Jordan's instructions to send these patches again?
Thanks Maurice -----Original Message----- From: Justen, Jordan L Sent: Monday, May 18, 2015 1:26 PM To: edk2-devel@lists.sourceforge.net; Dong, Guo; Ma, Maurice Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 0/2] *** SUBJECT HERE *** Can you please use git send-email *.patch from the git bash command line, rather than TortoiseGit when sending the email? TortoiseGit does not send the emails in a single email thread. While you are at it, you might as well just use git format-patch to generate the patch files. If you use a cover letter (0/N patch), then you should modify the "*** SUBJECT HERE ***" and "*** BLURB HERE ***" text. I think the cover letter should describe what is basically being fixed by the patch. I expect this allows CorebootModulePkg to be used with the current upstream coreboot. Why not let us know this? These patches do not have Contributed-under, as required by CorebootPayloadPkg/Contributions.txt. (Maurice, as maintainer you should reject (NAK) any patches without this.) Can you please send the patches to edk2-devel, and Cc the maintainer as mentioned in the Maintainers.txt file? Your first commit message looks like: === The latest coreboot use IMD (In Memory Database) to report Tables. This patch adds IMD support in UEFI payload. Signed-off-by: Guo Dong <guo.d...@intel.com> === How about this instead: === CorebootModulePkg/CbParseLib: Support current coreboot IMD The latest coreboot use IMD (In Memory Database) to report Tables. This patch adds IMD support in UEFI payload. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong <guo.d...@intel.com> === This better follows https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format A similar comment could be made about PATCH 2/2. Maurice, once again, I think you should reject patches that don't have a proper commit message. (Although the Contributed-under and Signed-off-by are definitely required.) -Jordan On 2015-05-18 08:29:31, Guo Dong wrote: > *** BLURB HERE *** > > Guo Dong (2): > The latest coreboot use IMD (In Memory Database) to report Tables. > This patch adds IMD support in UEFI payload. > Replace tab with space and remove the space at the end of lines. > > CorebootModulePkg/Include/Coreboot.h | 19 + > CorebootModulePkg/Library/CbParseLib/CbParseLib.c | 536 > +++++++++++----------- > 2 files changed, 298 insertions(+), 257 deletions(-) > > -- > 1.9.5.msysgit.0 ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
