Could you split it to 2 patches? One is specific for MdeModulePkg and another is for OpromPkg. Then different package owners could review your changes individually.
MdeModulePkg change is good: Reviewed-by: Feng Tian <feng.t...@intel.com> I will help check in the MdeModulePkg part. Thanks Feng -----Original Message----- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Friday, May 29, 2015 23:26 To: Tian, Feng; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] Bump default driver supported efi version to 2.5 Thanks. I've attached a new version of the patch. -- Bruce On 5/29/2015 2:41 AM, Tian, Feng wrote: > Hi, Bruce > > The modules in MdeModulePkg couldn't depend on OptionRomPkg. So your change > is not ok for me. > > I would prefer to directly assign 0x00020032 to > gNvmExpressDriverSupportedEfiVersion.FirmwareVersion. > > Thanks > Feng > > -----Original Message----- > From: Bruce Cran [mailto:br...@cran.org.uk] > Sent: Friday, May 29, 2015 09:18 > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] [PATCH] Bump default driver supported efi version to 2.5 > > I noticed that the default value used for the driver supported efi version > protocol was 0x2000a - UEFI 2.1. The attached patch bumps it to > 2.5 and updates the NvmExpress driver to use the Pcd from OptionRomPkg. > > -- > Bruce ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
