On 11/13/2014 01:55 PM, Danny Horn wrote:
Worked on Event-logging (L1) -- it's WIP, but it would be good for Matt to review the approach. One question -- When you start to reply, it'll fetch the handlebar template & compile it -- there's a slight delay. Not certain of the approach there; it may break on really slow JS or slow machines.
Can you explain the connection between this and the EventLogging? Is it some kind of race condition?
Could this be fixed by just calling FlowHandlebars.prototype.getTemplate on the template name before the user action (e.g. on ready). If I understand correctly, that will ensure the template is compiled by the time it returns, but not actually render anything.
One question -- right now, it'll only log things with JS, the no-JS case isn't covered. Is that something we want to do? (No for now -- it can be done as a v2 if we need it.)
See also https://bugzilla.wikimedia.org/show_bug.cgi?id=51854 (if we want to know how many people use Flow with JS completely off).
Matt Flaschen _______________________________________________ EE mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/ee
