On 2017-07-07 16:51, Claudius Heine wrote:
>>> + FILE *mtab = NULL;
>>> +
>>> + if ((mtab = setmntent("/proc/mounts", "r")) == NULL)
>>> + return NULL;
>>
>> What is now our coding style, with our without braces for single-line
>> blocks? This looks nicer to me, but then it should be consistent
>> across
>> the board.
>
> Are you proposing another patch to bring everything to the braces-less
> single line blocks or should this patch use braces?
>
> I too more like the brace-less format in these cases.
Can we encode that in the clang-format file? Andreas, any concerns?
>
>>
>>> +
>>> + while ((part = getmntent(mtab)) != NULL) {
>>> + if ((part->mnt_fsname != NULL) &&
>>> + (strcmp(part->mnt_fsname, devpath)) == 0) {
>>> + char *mntpoint;
>>> +
>>> + if (!(mntpoint =
>>> + malloc(strlen(part->mnt_dir) +
>>> 1))) {
>>
>> Assignment in if statement.
>
> Code was not changed (apart from indentation). Also not something the
> static code checkers complained about. So not something for this patch
> IMO.
Ah, sorry. Then leave it as is. But that should be addressed eventually,
in a separate patch.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/42546b36-3aef-b67c-e279-1f064607167a%40siemens.com.
For more options, visit https://groups.google.com/d/optout.
