On Wed, Aug 23, 2017 at 01:34:22PM +0200, Claudius Heine wrote:
> Hi,
> 
> On 08/22/2017 06:15 PM, [ext] Reichel Andreas wrote:
> > From: Andreas Reichel <[email protected]>
> > 
> > -                   fprintf(stderr, "Error opening output file.\n");
> > +                   fprintf(stderr, "Error opening output file %s.\n",
> > +                           envfilepath);
> 
> Here would be a strerror(3) string be useful. Maybe even check if the
> directory exists, etc. yourself.
> 

agreed

> >                     result = 1;
> >             }
> > +           free(envfilepath);
> 
> free without malloc? Could it be that you didn't even allocated space for
> envfilepath? ;)
> 
asprintf has integrated malloc, that's why the first parameter is a
pointer to a pointer.

Andreas


-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

[email protected], +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082

-- 
You received this message because you are subscribed to the Google Groups "EFI 
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/20170823125402.GA3524%40iiotirae.
For more options, visit https://groups.google.com/d/optout.

Reply via email to