On 2017-08-23 09:30, [ext] Claudius Heine wrote: > > > On 08/23/2017 03:04 PM, Andreas Reichel wrote: >> On Wed, Aug 23, 2017 at 01:03:22PM +0200, Claudius Heine wrote: >>> Hi, >>> >>> On 08/22/2017 06:15 PM, [ext] Reichel Andreas wrote: >>>> From: Andreas Reichel <[email protected]> >>>> >>>> From: Reichel Andreas <[email protected]>
Please fix your script to only generate the first line. Otherwise, I would have to edit all patches manually. >>>> >>>> Only create symlink if it is not there yet. >>>> >>>> Signed-off-by: Andreas Reichel <[email protected]> >>>> --- >>>> Makefile.am | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/Makefile.am b/Makefile.am >>>> index 6038f30..2ebc4b1 100644 >>>> --- a/Makefile.am >>>> +++ b/Makefile.am >>>> @@ -189,6 +189,6 @@ bg_printenv_DATA = bg_printenv >>>> bg_printenvdir = $(top_srcdir) >>>> bg_printenv: $(bg_setenv) >>>> - $(LN_S) bg_setenv bg_printenv >>>> + @if [ ! -e bg_printenv ]; then $(LN_S) bg_setenv bg_printenv; fi >>> >>> Doesn't make only executes this target if the file/symlink is not >>> current? >> Unfortunately not. >> >>> Maybe '$(LN_S) -f' is better for the case that it thinks its not >>> 'current'? >> Didn't like the force here as the link is always good if just kept. > > What is your reason for this? My reason is simplicity over complexity. > > If you insists on this, maybe write it like this: > > test -e bg_printenv || $(LN_S) bg_setenv bg_printenv > ln -f is a common pattern. Let's not over-optimize. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/1e5bbb68-1e74-10da-ebce-6a7fd8eadda2%40siemens.com. For more options, visit https://groups.google.com/d/optout.
