On 2017-09-11 17:25, Andreas Reichel wrote: > On Mon, Sep 11, 2017 at 04:21:04PM +0200, Jan Kiszka wrote: >> On 2017-09-11 13:35, [ext] Andreas J. Reichel wrote: >>> From: Reichel Andreas <[email protected]> >>> >>> Create symlink with -f option to avoid error if it already >>> exists. >>> >>> Signed-off-by: Andreas Reichel <[email protected]> >>> --- >>> Makefile.am | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/Makefile.am b/Makefile.am >>> index 6038f30..c6ebec4 100644 >>> --- a/Makefile.am >>> +++ b/Makefile.am >>> @@ -84,7 +84,7 @@ bg_setenv_DEPENDENCIES = \ >>> libbg_utils.a >>> >>> install-exec-hook: >>> - $(LN_S) bg_setenv$(EXEEXT) \ >>> + $(LN_S) -f bg_setenv$(EXEEXT) \ >>> $(DESTDIR)$(bindir)/bg_printenv$(EXEEXT) >>> >>> # >>> @@ -185,10 +185,11 @@ $(efi_loadername): $(efi_solib) >>> -j .dynsym -j .rel -j .rela -j .reloc -j .init_array \ >>> --target=efi-app-$(ARCH) $< $@ >>> >>> -bg_printenv_DATA = bg_printenv >>> bg_printenvdir = $(top_srcdir) >>> >>> bg_printenv: $(bg_setenv) >>> - $(LN_S) bg_setenv bg_printenv >>> + $(LN_S) -f bg_setenv bg_printenv >>> + >>> +all-local: bg_printenv >>> >>> CLEANFILES += bg_printenv >>> >> >> The changes around all-local are needed for this fix or an unrelated >> cleanup/fix? Not obvious to me at least. > This fix also affects the symlink creation - yes. The link was not > created under debian packaging test. Also, extending the all-target > is simpler than defining a strange _DATA variable imho.
For the future, just leave a note in the changelog for non-obvious but related changes. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/076590ff-9d7a-f03e-81d9-93c80fa302c5%40siemens.com. For more options, visit https://groups.google.com/d/optout.
