On 2017-09-27 10:03, Claudius Heine wrote: > Hi Jan, > > On 09/27/2017 09:25 AM, Jan Kiszka wrote: >> On 2017-09-26 15:22, [ext] [email protected] wrote: >>> From: Claudius Heine <[email protected]> >>> >>> Signed-off-by: Claudius Heine <[email protected]> >>> --- >>> .travis.yml | 19 ++++++++++++++++++- >>> 1 file changed, 18 insertions(+), 1 deletion(-) >>> >>> diff --git a/.travis.yml b/.travis.yml >>> index 4fa4045..db7c1f6 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -15,6 +15,10 @@ env: >>> - TARGET=native >>> - TARGET=i586 >>> - TARGET=cppcheck >>> + global: >>> + # The next declaration is the encrypted COVERITY_SCAN_TOKEN, created >>> + # via the "travis encrypt" command using the project repo's >>> public key >>> + - secure: "" >> >> Don't get the role of this statement yet, specifically not from the >> comment. We don't have this in Jailhouse as well. So, either this >> statement is unneeded, or we have a gap in our Jailhouse config. > > You need to insert the security token you get from coverity here. I > deleted mine before sending this patch.
Still no explanation why we need "- secure:". OK, I will try removing that statement to see if there is a real need (unlikely, given that Jailhouse also works fine without it). > >> >>> language: c >>> compiler: >>> @@ -22,11 +26,24 @@ compiler: >>> sudo: required >>> +before_install: >>> + - echo -n | openssl s_client -connect scan.coverity.com:443 | >>> sed -ne '/-BEGIN CERTIFICATE-/,/-END CERTIFICATE-/p' | sudo tee -a >>> /etc/ssl/certs/ca- >> >> Something is missing here, must end with >> "/etc/ssl/certs/ca-certificates.crt" > > That is exactly how coverity suggets setting up travis with it. I trust > they know what they are doing here and it seems to work well. > Then your patch is buggy, cutting off the line early. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/079187de-ffed-76b1-1f63-6f1494d57412%40siemens.com. For more options, visit https://groups.google.com/d/optout.
