Hi Farhat, Thank you - next time, please also update the version number in your patch series (e.g. using --subject-prefix="PATCH v4")
Cedric -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Abbas, Farhat Sent: Wednesday, February 21, 2018 1:30 PM To: Andreas Reichel <[email protected]> Cc: [email protected] Subject: [Bulk] RE: [PATCH 0/6] *** SUBJECT HERE *** Updated as suggested! Regards, Farhat Abbas | Software Development Engineer Mentor EmbeddedT | 6th Floor, Ali Tower, 105 B2 M. M Alam Road, Gulberg III, Lahore, Pakistan, 54660 P +92-42-3609-9254 | M +92-343-7750571 -----Original Message----- From: Andreas Reichel [mailto:[email protected]] Sent: Wednesday, February 21, 2018 4:59 PM To: Abbas, Farhat <[email protected]> Cc: [email protected] Subject: Re: [PATCH 0/6] *** SUBJECT HERE *** On Wed, Feb 21, 2018 at 04:11:10PM +0500, Farhat wrote: > From: Farhat-Abbas <[email protected]> > Okay, thanks. But if you look at the text below, it is formated in a quite non-standard way. The problem is, that in your commit messages, you put the whole text into the subject line. The subject of a commit should be kept short - then an empty line - then the commit messages that describes what the commit does. If you look at other patch series on the mailing list, you can see what I mean. Also, the *** SUBJECT HERE *** field and the *** BLURB HERE *** fields are ment to be replaced by you to contain some kind of summary text what the whole series is about. Maybe you want to rework this once more. Kind regards, Andreas > *** BLURB HERE *** > > Farhat-Abbas (6): > DEPLOY_DIR_IMAGE-Issue-Resolved Required artifacts, to be copied, > are available in 'DEPLOY_DIR_IMAGE' directory pointed to by > 'kernel_dir'. The recipe efibootguard.bb stages efibootguard > bootloader to 'DEPLOY_DIR_IMAGE'. So, efibootguard should be > copied from 'kernel_dir'. OE-Core's script > 'oe-core/scripts/lib/wic/plugins/source/bootimg-efi.py' is used as > reference. Also, 'HDDDIR' has been removed from 'WICVARS' & > won't be accessible in scripts. 'HDDDIR' was populated ONLY if > 'NOHDD=1' but images can be built w/o it, so it was optional but > 'DEPLOY_DIR_IMAGE' is always populated with the required artifacts. > WIC Error Handling is broken, no module named 'os_exit()' is > available. > Remove Extra Imports, that are not being used at all. > INITRD file must be copied to BOOT partition when specified. > INITRD files are available in 'DEPLOY_DIR_IMAGE' directory pointed > to by 'kernel_dir'. It can be copied to BOOT partition, when > specified in 'source-params' by WKS file. OE-Core's script > 'oe-core/scripts/lib/wic/plugins/source/bootimg-efi.py' is used as > reference. > Copy only the efibootguard bootloader to the EFI partition properly. > There isn't any EFI/BOOT directory in the 'DEPLOY_DIR_IMAGE' > directory & efibootguard is present at top level in it, possibly > alongwith other *efi bootloaders like grub-efi. Only > efibootguard bootloader should be copied to the image from here, > in the required architecture specific naming convention. This > patch updates the script to the latest OE-Core tree with file > 'oe-core/scripts/lib/wic/plugins/source/bootimg-efi.py' as > reference. > Updated README file, tested with updated Poky(rocko) > > README.md | 6 +++--- > .../lib/wic/plugins/source/efibootguard-boot.py | 21 +++++++++++++++------ > scripts/lib/wic/plugins/source/efibootguard-efi.py | 22 > ++++++++++++++-------- > 3 files changed, 32 insertions(+), 17 deletions(-) > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups > "EFI Boot Guard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/1519211476-6350-1-git-send-email-Farhat_Abbas%40mentor.com. > For more options, visit https://groups.google.com/d/optout. -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant [email protected], +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082 -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/91c9eb0ecbf14313b59bacbe3e9aadce%40svr-ies-mbx-02.mgc.mentorg.com. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/8161b683f8dc473a92e977926428fd52%40svr-ies-mbx-02.mgc.mentorg.com. For more options, visit https://groups.google.com/d/optout.
