On 2018-05-02 13:44, Andreas Reichel wrote: > On Wed, May 02, 2018 at 01:27:27PM +0200, Jan Kiszka wrote: >> On 2018-04-27 14:44, Andreas J. Reichel wrote: >>> From: Andreas Reichel <[email protected]> >>> >>> Provide possibility to register user variables that are deleted >>> on finalization of an update. >>> >>> Signed-off-by: Andreas Reichel <[email protected]> >>> --- >>> env/env_api.c | 45 ++++++++++++++++++++++++++++++++++++++++++++- >>> include/ebgenv.h | 8 ++++++++ >>> include/env_api.h | 5 +++++ >>> 3 files changed, 57 insertions(+), 1 deletion(-) >>> >>> diff --git a/env/env_api.c b/env/env_api.c >>> index 75695d1..03cd53c 100644 >>> --- a/env/env_api.c >>> +++ b/env/env_api.c >>> @@ -240,10 +240,53 @@ int ebg_env_close(ebgenv_t *e) >>> return 0; >>> } >>> >>> -int ebg_env_finalize_update(ebgenv_t *e) { >>> +int ebg_env_gc_register_var(ebgenv_t *e, char *key) >> >> "Register garbage-collected variable" - ebg_env_register_gc_var, I would >> say. >> > We already discussed that on the last mail. gc is the superior name > here. Other functions could follow. >
See, my memory is getting weak, but my intuition still tells me we are using a wrong pattern here. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/590e6c1e-5a79-7786-22e9-90210b6047f8%40siemens.com. For more options, visit https://groups.google.com/d/optout.
