On Mon, May 28, 2018 at 03:46:03PM +0200, Claudius Heine wrote: > > > On 2018-05-25 14:01, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <[email protected]> > > > > * volumes[] already contains all needed data, so instead of > > allocating two additional arrays (roots, root_devpaths), > > just create a mapping config_volumes[] and use > > volumes[config_volumes[]] > > * remove CONFIG_PARTITION_MAXCOUNT, since the maximum number of > > config partitions is always the number of volumes present > > * simplify error-handling in config loading and writing > > > > Signed-off-by: Andreas Reichel <[email protected]> > > --- > > env/fatvars.c | 121 ++++++++++++++++++---------------------------- > > env/syspart.c | 27 +++++------ > > include/envdata.h | 2 - > > include/syspart.h | 8 +-- > > 4 files changed, 60 insertions(+), 98 deletions(-) > > > > diff --git a/env/fatvars.c b/env/fatvars.c > > index cefff0c..556b836 100644 > > - mfree(root_devices); > > - mfree(roots); > > - return BG_CONFIG_ERROR; > > + goto scc_cleanup; > > Yep that is the kind of thing I don't like in patchsets :) Don't add code in > one patch and then change it again in one of the next ones. > > If you want to fix this, then take a look at 'git add -p'. > > You could also split the implementation of the fail-safe from the > integration and maybe merge that into this patch if that is easier. > > Or just merge 9 and 10. >
As our long discussion just pointed out, merging 9 and 10 seems to be the best solution. > > > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected] -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant [email protected], +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082 -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/20180528142005.GA2715%40iiotirae. For more options, visit https://groups.google.com/d/optout.
