On 10/7/19 10:22 AM, Jan Kiszka wrote: > On 07.10.19 15:54, Mathieu Alexandre-Tétreault wrote: >> From: "Mathieu A.-Tetreault" <[email protected]> >> >> As per the linux kernel documentation: >> The iTCO v1 and v2's internal timer is stored as ticks which decrement >> every 0.6 seconds. v3's internal timer is stored as seconds (some >> datasheets incorrectly state 0.6 seconds). >> >> https://github.com/torvalds/linux/blob/master/drivers/watchdog/iTCO_wdt.c#L136 >> >> This have been tested on an iTCOv3 board. > Yeah, I think our v2 vs. v3 discussion somewhere stranded without any > conclusion.
Indeed, that is my fault. I took a one year paternity leave :) I am now back, I'll take the time this week to take care of this. I am sorry about that. >> Signed-off-by: Mathieu A.-Tetreault <[email protected]> >> --- >> drivers/watchdog/itco.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/watchdog/itco.c b/drivers/watchdog/itco.c >> index f46379d..8346f36 100644 >> --- a/drivers/watchdog/itco.c >> +++ b/drivers/watchdog/itco.c >> @@ -97,7 +97,7 @@ init(EFI_PCI_IO *pci_io, UINT16 pci_vendor_id, UINT16 >> pci_device_id, >> return status; >> } >> value &= 0xfc00; >> - value |= ((timeout * 10) / 6) & 0x3ff; >> + value |= timeout & 0x3ff; >> status = uefi_call_wrapper(pci_io->Io.Write, 6, pci_io, >> EfiPciIoWidthUint16, >> EFI_PCI_IO_PASS_THROUGH_BAR, >> > Christian, you said you refactored things in this area as well. Does > this collide or is this orthogonal? > > Thanks, > Jan > -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/e35ecd90-b1c3-6ff9-ea56-c1f9868503ba%40amotus.ca.
