On 02.09.20 12:00, Awan, Arsalan wrote: >> OK, just missed my first review comment. But we can sort out read/in >> error handling while factoring out those helpers in-tree. >> >> Applied to next. >> > Arsalan: > Appreciate that! Thanks! >
Some update after trying out the driver on my new R1505G. The good news: - efibootguard detects and configures the watchdog correctly - the upstream kernel driver picks up the watchdog - if not, the system resets after the timeout The bad ones: - there is no lock-down of the watchdog, and a distro kernel will simply turn it off until some watchdog service may pick it up again - the upstream driver only works after efibootguard enabled the watchdog - likely fixable, though, and likely the reason why the misunderstanding arose that the kernel does not support this hardware Did you check the specifications for a potential hw-assisted locking / no-way-out mode? Not having that significantly decreases the value of this watchdog unfortunately. It could be partially mitigated by changing the kernel driver to detect a running watchdog and avoid turning it off unless explicitly requested. That what w83627hf_wdt.c does e.g. I have that one on my board as well, and it also lacks any lock-down support. Jan -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/41010729-c6e1-db64-e4dd-77ee96f1a399%40web.de.
