On 01/12/2020 15:14, Jan Kiszka wrote:
> On 01.12.20 15:06, [ext] Silvano Cirujano Cuesta wrote:
>> Changes V3: rebased on next
>>
>> Silvano Cirujano Cuesta (2):
>>   Support printenv direct from file
>>   refactor: move code to functions
>>
> ...but not reordered. Sorry, but this is a common pattern: You want to
> add something that requires some factoring, do that first.
>
> Jan

I also do refactoring before changing. Except if, like in this case, the 
refactoring is only motivated by my changes.

But I can reorder it, not a big deal.

Silvano

>
>>  env/env_api_fat.c         |   4 +-
>>  env/env_config_file.c     |  18 ++++--
>>  include/env_config_file.h |   3 +-
>>  tools/bg_setenv.c         | 133 +++++++++++++++++++++++++++-----------
>>  4 files changed, 115 insertions(+), 43 deletions(-)
>>

-- 
You received this message because you are subscribed to the Google Groups "EFI 
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/d5d332e7-c6ba-c8c9-00cd-7123fcb875f8%40siemens.com.

Reply via email to