Hi Jan,
> >> Lost a newline here. Fixing up while dropping that INFO tag.
> >
> > Hm, why did you remove the
> > do { ... } while (0)
> > enclosing in INFO() while your modifications of the patch?
> >
> > It now reads (see [1])
> > #define INFO(fmt, ...) \
> > PrintC(EFI_LIGHTGRAY, fmt, ##__VA_ARGS__);
> > which means it effectively expands to double ;; and it breaks,
> > e.g., for some if-else constructs such as
> > if (condition)
> > INFO(L"foo");
> > else
> > ERROR(L"bar");
> > as the double ;; "eats" the else part so the compiler is unhappy.
> >
> > Is there a reason for this I'm missing?
> >
>
> Nope, I just missed the remove the additional ";" as well. Fixed.
OK, github has catched up now. I'm fine with your modifications.
Nit picking: There's a typo in your modification explanation:
"[Jan: rebase & rewrap, using long lines to make error stings
searchable, dropped prefix of INFO output]"
stings → strings.
Kind regards,
Christian
--
Dr. Christian Storm
Siemens AG, Technology, T RDA IOT SES-DE
Otto-Hahn-Ring 6, 81739 München, Germany
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/20210114095045.xcgnd6bcssexh2g6%40MD1ZFJVC.ad001.siemens.net.
