On 03.11.21 09:40, Michael Adler wrote: > Hi all, > > as promised a while back [1], here is my extension of bg_printenv. It didn't > make it in time for the 0.9 release, but > I first had to set up some automated testing [2] to prevent regressions. > > (There is still a blank spot in our test coverage, i.e. cli tests which do > not use the envfile parameter. This is a bit > tricky, since it requires setting up a (loopback) device and I'm not sure if > this would work in CI. These kind of tests > I have performed manually. Maybe I can revisit this topic if we can agree on > the patches.) > > Looking forward to any feedback.
Thanks for the patches! 3 and 4 look rather large, and both do multiple things at once. Can they by reasonably split along those things? Would simplify review. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/79eae0cd-a06d-23c7-452f-e57ca1bf3000%40siemens.com.
