On 10.08.22 11:19, Schmidl, Tobias wrote: > Hi all, > > Am Mittwoch, dem 10.08.2022 um 09:59 +0200 schrieb Jan Kiszka: >> >> - please make sure all patches have a commit message providing a >> brief (or longer, in complex cases) reasoning for the change >> > > Thanks, will do. > >> - do not blindly copy file headers from existing files in to new one >> but also update them as needed ;) >> > > Thanks, fixed. > >> >> And where in the patches are the external parser files you mentioned? >> Didn't find them yet, but I might have been blind. >> > > No, you're not. They are just implicitly mentioned in Makefile.am [1] by > linking against libiniparser.a. What's missing (and will be fixed in a v2) > is a mention in COMPILE.md. > > I went with iniparser [2], a small four-file library that links > statically. >
As we discussed offline: Given that the files are not packaged by a distro (specifically as they are shipped as source, not as a lib) and also due to the possibility of having to modify them, I would suggest to include those in-tree as copy / fork for now. Jan -- Siemens AG, Technology Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/a01bb737-db5e-6eec-9a78-887acfb602f3%40siemens.com.
