Hello Tobias,
We have a BX-59A/BX-56A device, during integration using efibootguard v0.16
we have found the BX-56A showing unsupported watchdog for "w83627hf", can
you please assist hear these patches will help us get watchdog integrated
well with updated efibootguard?
also please advise will these be integrated with upstream efibootguard?
Thanks
Shrikant Bobade
On Monday 8 April, 2024 at 8:11:52 pm UTC+5:30 Jan Kiszka wrote:
> On 08.04.24 16:40, Jan Kiszka wrote:
> > On 27.03.24 09:19, Tobias Schaffner wrote:
> >> The simatic IPC BX-56A shares the same nct6116 superio chip as the
> >> BX-59A. Allow efibootguard to configure the w83627hf watchdog for BX-56A
> >> by adding its station id.
> >>
> >> Signed-off-by: Tobias Schaffner <tobias.s...@siemens.com>
> >> ---
> >> drivers/watchdog/w83627hf_wdt.c | 3 ++-
> >> include/simatic.h | 1 +
> >> 2 files changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/watchdog/w83627hf_wdt.c
> b/drivers/watchdog/w83627hf_wdt.c
> >> index df1da11..fd2950d 100644
> >> --- a/drivers/watchdog/w83627hf_wdt.c
> >> +++ b/drivers/watchdog/w83627hf_wdt.c
> >> @@ -208,11 +208,12 @@ static EFI_STATUS init(EFI_PCI_IO *pci_io, UINT16
> pci_vendor_id,
> >> }
> >>
> >> switch (simatic_station_id()) {
> >> + case SIMATIC_IPCBX_56A:
> >> case SIMATIC_IPCBX_59A:
> >> chip = wdt_find(0x2e);
> >> if (chip < 0)
> >> return EFI_UNSUPPORTED;
> >> - INFO(L"Detected SIMATIC BX59A watchdog\n");
> >> + INFO(L"Detected SIMATIC BX5xA watchdog\n");
> >> ret = w83627hf_init(chip);
> >> if (ret < 0)
> >> return EFI_UNSUPPORTED;
> >> diff --git a/include/simatic.h b/include/simatic.h
> >> index 724e79d..43c5515 100644
> >> --- a/include/simatic.h
> >> +++ b/include/simatic.h
> >> @@ -25,6 +25,7 @@
> >>
> >> #define SIMATIC_IPC427E 0x0a01
> >> #define SIMATIC_IPC477E 0x0a02
> >> +#define SIMATIC_IPCBX_56A 0x1201
> >> #define SIMATIC_IPCBX_59A 0x1202
> >>
> >> typedef struct {
> >
> > Needs README.md update as well. And some comments in w83627hf_wdt.c.
>
> Ok, comments are removed with patch 2, so you can leave them untouched.
>
> Jan
>
> --
> Siemens AG, Technology
> Linux Expert Center
>
>
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to efibootguard-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/b2f89a02-95b7-44de-9cb7-e55be812da00n%40googlegroups.com.
