On 16.05.24 11:18, Tobias Schaffner wrote:
> This series adds the station id of the BX-56A and allows to run the
> driver for all configurations of the BX-56A and BX-59A.
> 
> As the host bridge device id varies over the different configurations,
> we only depend on the pci vendor and station id.
> 
> This has been tested on both the BX-56A and the BX-59A.
> 
> changes since v1:
> - move caching of station id out of the driver into to the simatic interface
> - address other review comments
> 
> Tobias Schaffner (3):
>   w83627hf: Add station id of IPC BX-56A
>   w83627hf: Solely depend on pci vendor and station id
>   Cache simatic station id
> 
>  drivers/utils/simatic.c         | 11 ++++++++++-
>  drivers/watchdog/w83627hf_wdt.c | 14 +++++---------
>  include/simatic.h               |  1 +
>  3 files changed, 16 insertions(+), 10 deletions(-)
> 

Welcome back (I mis-predicted it to be later)! :)

Looks generally good, but we still need a small README update to add
56A, and I would suggest to reorder patch 2 and 3 (which minor commit
message adjustment).

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "EFI 
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to efibootguard-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/be2bc961-8baa-4bcd-9005-a8d8ffff7bd3%40siemens.com.

Reply via email to