Hey,
On Thu, 2024-05-16 at 12:00 +0200, Jan Kiszka wrote:
> On 16.05.24 11:52, 'Sjoerd Simons' via EFI Boot Guard wrote:
> > This adds support for Tiger lake LP, Jasper lake, Alder lake
> > (various
> > variants), Raptor lake, Meteor lake (various variants) and Birch
> > Stream devices using the relevant pci-ids and chip namings from the
> > linux kernel.
> >
> > Tested on Dell Optiplex 7000 and Optiplex E4 with Alder Lake-S
> > chipsets.
> >
>
> Thanks for the contribution! Just one concern: As we are not using
> the
> exact same enabling logic in EBG compared to the kernel, I'm always a
> bit reluctant to merge support for devices that were not tried in
> real
> life. So, we have 2 of the 10 additions actually tested, right? Can
> you
> explain why the other 8 are a "safe bet"? Or can we extend the on-
> device
> test coverage?
As they're all itco v6 watchdogs you'd hope it's a pretty safe bet,
assuming the EBG code does reasonable things. The kernel for sure
doesn't further differentiate between different instances/generations.
I'm happy to limit the patch to just chipsets/generations we've tested
on though if that's the preference. It just makes efibootguard a bit
more cumbersome to adopt for new hardware
>
> Jan
>
> > Signed-off-by: Sjoerd Simons <sjo...@collabora.com>
> > ---
> > drivers/watchdog/itco.c | 72
> > ++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 71 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/itco.c b/drivers/watchdog/itco.c
> > index 9252014..f268a35 100644
> > --- a/drivers/watchdog/itco.c
> > +++ b/drivers/watchdog/itco.c
> > @@ -40,6 +40,16 @@ enum iTCO_chipsets {
> > ITCO_INTEL_WBG,
> > ITCO_INTEL_EHL,
> > ITCO_INTEL_TLH,
> > + ITCO_INTEL_TL_LP,
> > + ITCO_INTEL_JL,
> > + ITCO_INTEL_AL_S,
> > + ITCO_INTEL_AL_P,
> > + ITCO_INTEL_AL_M,
> > + ITCO_INTEL_RL_S,
> > + ITCO_INTEL_ML_P,
> > + ITCO_INTEL_ML_SOC_S,
> > + ITCO_INTEL_ML_PCH_S,
> > + ITCO_INTEL_BS,
> > };
> >
> > enum iTCO_versions {
> > @@ -62,7 +72,7 @@ typedef struct {
> > } iTCO_regs;
> >
> > typedef struct {
> > - CHAR16 name[16];
> > + CHAR16 name[32];
> > UINT32 pci_id;
> > UINT32 itco_version;
> > } iTCO_info;
> > @@ -163,6 +173,66 @@ static const iTCO_info iTCO_chipset_info[] = {
> > .pci_id = 0x43a3,
> > .itco_version = ITCO_V6,
> > },
> > + [ITCO_INTEL_TL_LP] =
> > + {
> > + .name = L"Tiger Lake-LP",
> > + .pci_id = 0xa0a3,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_JL] =
> > + {
> > + .name = L"Jasper Lake",
> > + .pci_id = 0x4da3,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_AL_S] =
> > + {
> > + .name = L"Alder Lake-S",
> > + .pci_id = 0x7aa3,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_AL_P] =
> > + {
> > + .name = L"Alder Lake-P",
> > + .pci_id = 0x51a3,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_AL_M] =
> > + {
> > + .name = L"Alder Lake-M",
> > + .pci_id = 0x54a3,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_RL_S] =
> > + {
> > + .name = L"Raptor Lake-S",
> > + .pci_id = 0x7a23,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_ML_P] =
> > + {
> > + .name = L"Meteor Lake-P",
> > + .pci_id = 0x7e22,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_ML_SOC_S] =
> > + {
> > + .name = L"Meteor Lake SoC-S",
> > + .pci_id = 0xae22,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_ML_PCH_S] =
> > + {
> > + .name = L"Meteor Lake PCH-S",
> > + .pci_id = 0x7f23,
> > + .itco_version = ITCO_V6,
> > + },
> > + [ITCO_INTEL_BS] =
> > + {
> > + .name = L"Birch Stream",
> > + .pci_id = 0x5796,
> > + .itco_version = ITCO_V6,
> > + },
> > };
> >
> > static BOOLEAN itco_supported(UINT16 pci_device_id, UINT8 *index)
>
--
Sjoerd Simons
Collabora Ltd.
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to efibootguard-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/dc108fdfc63cfa7b6af4a380362ced2c539785a7.camel%40collabora.com.
